From issues-return-157810-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Mar 12 05:39:44 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3108118060F for ; Mon, 12 Mar 2018 05:39:44 +0100 (CET) Received: (qmail 34097 invoked by uid 500); 12 Mar 2018 04:39:42 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 34084 invoked by uid 99); 12 Mar 2018 04:39:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2018 04:39:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B20A1E96D5; Mon, 12 Mar 2018 04:39:41 +0000 (UTC) From: walterddr To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #5555: [FLINK-8689][table]Add runtime support of distinct filter... Content-Type: text/plain Message-Id: <20180312043941.B20A1E96D5@git1-us-west.apache.org> Date: Mon, 12 Mar 2018 04:39:41 +0000 (UTC) Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5555 Thanks @hequn8128 for the prompt review. Are you suggesting we created the mapView parallel with the accumulator? The reason why I kept `DistinctAccumulator` is to act as a delegate to enclose the actual accumulator so that it can be passed around in the `accumulatorState` field without extending the arity. I guess if we separate the mapView with the accumulator. I guess I can separately create another field in the `accumulatorState` `Row` to store the `mapView`(s)... This way it might be easier to handle the "reuse same mapView for multiple different distinct agg function" case as we discussed in the doc. Another question is I was trying to reuse as much utility of dataview codegen as possible, as most of them are tightly coupled with the accumulators. I guess I can further refactor (which I already did quite a bit already). Please let me know if that's what you had in mind @hequn8128 -- Rong ---