flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianran <...@git.apache.org>
Subject [GitHub] flink pull request #5686: [FLINK-8917] [Job-Submission] FlinkMiniCluster def...
Date Tue, 13 Mar 2018 01:39:00 GMT
GitHub user jianran opened a pull request:

    https://github.com/apache/flink/pull/5686

    [FLINK-8917] [Job-Submission] FlinkMiniCluster default createHighAvailabilityServices
is not same as ClusterClient

    
    ## What is the purpose of the change
    
    the FlinkMiniCluster used
    HighAvailabilityServicesUtils.createAvailableOrEmbeddedServices to create highAvailabilityServices,so
the FlinkMiniCluster's highAvailabilityServices is EmbeddedHaServices, but the ClusterClient
used
    HighAvailabilityServicesUtils.createHighAvailabilityServices,so the so ClusterClient's
highAvailabilityServices is StandaloneHaServices; the  highAvailabilityServicess are different,
if you use the flink-1.4 in zeppelin,the zeppelin use FlinkMiniCluster to submit job, the
job submission will be failed with the follow msg:
    
    Discard message LeaderSessionMessage(00000000-0000-0000-0000-000000000000,SubmitJob(JobGraph(jobId:
33d8e7d74aa48f76a1622d4d8f78105e),EXECUTION_RESULT_AND_STATE_CHANGES)) because the expected
leader session ID 87efb7ca-b761-4977-9696-d521bc178703 did not equal the received leader session
ID 00000000-0000-0000-0000-000000000000.
    
    so this pull request will to change the FlinkMiniCluster use HighAvailabilityServicesUtils.createHighAvailabilityServices
to create StandaloneHaServices as same as the ClusterClient created
    ## Brief change log
    
    *(for example:)*
      - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
      - *Deployments RPC transmits only the blob storage reference*
      - *TaskManagers retrieve the TaskInfo from the blob cache*
    
    
    ## Verifying this change
    
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    This change is already covered by existing tests, such as LocalFlinkMiniClusterITCase.
    
    ## Does this pull request potentially affect one of the following parts:
    
       - Dependencies (does it add or upgrade a dependency):no 
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
      - The serializers:  don't know
      - The runtime per-record code paths (performance sensitive):  don't know
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector:no
    
    ## Documentation
      - Does this pull request introduce a new feature? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jianran/flink release-1.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5686
    
----
commit 4aa4e8d27f602f7dfeadc07c5b76498afb044f06
Author: jianran.tfh <jianran.tfh@...>
Date:   2018-03-13T01:08:19Z

    [FLINK-8917] [Job-Submission] FlinkMiniCluster haService not same as ClusterClient

----


---

Mime
View raw message