flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sihuazhou <...@git.apache.org>
Subject [GitHub] flink pull request #5635: [FLINK-8859][state backend] RocksDB backend should...
Date Mon, 05 Mar 2018 12:32:56 GMT
GitHub user sihuazhou opened a pull request:


    [FLINK-8859][state backend] RocksDB backend should pass WriteOption to Rocks.put() when

    ## What is the purpose of the change
    This PR fixes [FLINK-8859](https://issues.apache.org/jira/browse/FLINK-8859). We should
pass `WriteOption` to Rocks.put() when restoring from handle (Both in full & incremental
checkpoint). Because of `WriteOption.setDisableWAL(true)`, the performance can be increased
by about 2 times.
    ## Brief change log
      - pass WriteOption to Rocks.put() when restoring
    ## Verifying this change
    The changes can be verified by existing tests.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink pass_writeoption_2_put

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5635
commit 08109cb20d26bd1c8a04455b2fa914807a730a28
Author: sihuazhou <summerleafs@...>
Date:   2018-03-05T12:21:27Z

    Pass the WriteOption to RocksDB.put() when restoring from handle.



View raw message