flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8976) End-to-end test: Resume with different parallelism
Date Fri, 23 Mar 2018 09:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411067#comment-16411067
] 

ASF GitHub Bot commented on FLINK-8976:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5745#discussion_r176677259
  
    --- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
    @@ -17,11 +17,25 @@
     # limitations under the License.
     ################################################################################
     
    +if [ -z $1 ] || [ -z $2 ]; then
    +  echo "Usage: ./test_resume_savepoint.sh <original_dop> <new_dop>"
    +  exit 1
    +fi
    +
     source "$(dirname "$0")"/common.sh
     
    -# modify configuration to have 2 slots
    +ORIGINAL_DOP=$1
    +NEW_DOP=$2
    +
    +if (( $ORIGINAL_DOP >= $NEW_DOP )); then
    +  NUM_SLOTS=$(( $ORIGINAL_DOP + 1 ))
    +else
    +  NUM_SLOTS=$(( $NEW_DOP + 1 ))
    +fi
    +
    +# modify configuration to have enough slots
     cp $FLINK_DIR/conf/flink-conf.yaml $FLINK_DIR/conf/flink-conf.yaml.bak
    -sed -i -e 's/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: 2/' $FLINK_DIR/conf/flink-conf.yaml
    +sed -i -e "s/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: $NUM_SLOTS/"
$FLINK_DIR/conf/flink-conf.yaml
     
     # modify configuration to use SLF4J reporter; we will be using this to monitor the state
machine progress
     cp $FLINK_DIR/opt/flink-metrics-slf4j-1.6-SNAPSHOT.jar $FLINK_DIR/lib/
    --- End diff --
    
    can we define the version as an environment variable in the common.sh?


> End-to-end test: Resume with different parallelism
> --------------------------------------------------
>
>                 Key: FLINK-8976
>                 URL: https://issues.apache.org/jira/browse/FLINK-8976
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Similar to FLINK-8975, we should have an end-to-end test which resumes a job with a different
parallelism after taking 
> a) a savepoint
> b) from the last retained checkpoint



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message