flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8966) Port AvroExternalJarProgramITCase to flip6
Date Wed, 28 Mar 2018 18:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417878#comment-16417878
] 

ASF GitHub Bot commented on FLINK-8966:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5766#discussion_r177843186
  
    --- Diff: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroExternalJarProgramITCase.java
---
    @@ -44,49 +39,24 @@
     
     	private static final String TEST_DATA_FILE = "/testdata.avro";
     
    -	@Test
    -	public void testExternalProgram() {
    -
    -		LocalFlinkMiniCluster testMiniCluster = null;
    +	private static final MiniClusterResource miniClusterResource = new MiniClusterResource(
    +		new MiniClusterResource.MiniClusterResourceConfiguration(
    +			new Configuration(),
    +			1,
    +			4));
     
    +	@Test
    +	public void testExternalProgram() throws Exception {
    +		miniClusterResource.setJarFiles(Collections.singleton(new Path(JAR_FILE)));
    --- End diff --
    
    The jar passed to the `PackagedProgram` is only used to create the classloader for loading
the contained classes.
    
    The jars have to be explicitly added to the JobGraph, which we here do by passing it to
the environment that does it for us. In the CLI, we use [PackagedProgramUtils](https://github.com/apache/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramUtils.java)
to retrieve the jars from the PackagedProgram and register them on the jobgraph.


> Port AvroExternalJarProgramITCase to flip6
> ------------------------------------------
>
>                 Key: FLINK-8966
>                 URL: https://issues.apache.org/jira/browse/FLINK-8966
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message