flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8964) Port JobSubmissionFailsITCase to flip6
Date Thu, 22 Mar 2018 16:34:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409833#comment-16409833
] 

ASF GitHub Bot commented on FLINK-8964:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5727#discussion_r176487184
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/example/failing/JobSubmissionFailsITCase.java
---
    @@ -105,90 +85,51 @@ public JobSubmissionFailsITCase(boolean detached) {
     
     	// --------------------------------------------------------------------------------------------
     
    -	private JobExecutionResult submitJob(JobGraph jobGraph) throws Exception {
    -		if (detached) {
    -			cluster.submitJobDetached(jobGraph);
    -			return null;
    -		}
    -		else {
    -			return cluster.submitJobAndWait(jobGraph, false, TestingUtils.TESTING_DURATION());
    -		}
    -	}
    -
     	@Test
    -	public void testExceptionInInitializeOnMaster() {
    -		try {
    -			final JobVertex failingJobVertex = new FailingJobVertex("Failing job vertex");
    -			failingJobVertex.setInvokableClass(NoOpInvokable.class);
    -
    -			final JobGraph failingJobGraph = new JobGraph("Failing testing job", failingJobVertex);
    +	public void testExceptionInInitializeOnMaster() throws Exception {
    +		final JobVertex failingJobVertex = new FailingJobVertex("Failing job vertex");
    +		failingJobVertex.setInvokableClass(NoOpInvokable.class);
     
    -			try {
    -				submitJob(failingJobGraph);
    -				fail("Expected JobExecutionException.");
    -			}
    -			catch (JobExecutionException e) {
    -				assertEquals("Test exception.", e.getCause().getMessage());
    -			}
    -			catch (Throwable t) {
    -				t.printStackTrace();
    -				fail("Caught wrong exception of type " + t.getClass() + ".");
    -			}
    +		final JobGraph failingJobGraph = new JobGraph("Failing testing job", failingJobVertex);
     
    -			cluster.submitJobAndWait(workingJobGraph, false);
    -		}
    -		catch (Exception e) {
    -			e.printStackTrace();
    -			fail(e.getMessage());
    -		}
    -	}
    +		ClusterClient<?> client = MINI_CLUSTER_RESOURCE.getClusterClient();
    +		client.setDetached(detached);
     
    -	@Test
    -	public void testSubmitEmptyJobGraph() {
     		try {
    -			final JobGraph jobGraph = new JobGraph("Testing job");
    -
    -			try {
    -				submitJob(jobGraph);
    -				fail("Expected JobSubmissionException.");
    -			}
    -			catch (JobSubmissionException e) {
    -				assertTrue(e.getMessage() != null && e.getMessage().contains("empty"));
    +			client.submitJob(failingJobGraph, JobSubmissionFailsITCase.class.getClassLoader());
    +			fail("Job submission should have thrown an exception.");
    +		} catch (Exception e) {
    +			Optional<Throwable> expectedCause = ExceptionUtils.findThrowable(e,
    +				candidate -> candidate.getMessage() != null && candidate.getMessage().equals("Test
exception."));
    --- End diff --
    
    could be simplified by `"Test exception.".equals(candidate.getMessage)`


> Port JobSubmissionFailsITCase to flip6
> --------------------------------------
>
>                 Key: FLINK-8964
>                 URL: https://issues.apache.org/jira/browse/FLINK-8964
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message