flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8927) Eagerly release the checkpoint object created from RocksDB
Date Mon, 12 Mar 2018 14:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395308#comment-16395308
] 

ASF GitHub Bot commented on FLINK-8927:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5682

    [FLINK-8927][state] Eagerly release the checkpoint object created from RocksDB

    ## What is the purpose of the change
    
    This PR addresses [FLINK-8927](https://issues.apache.org/jira/browse/FLINK-8927), eagerly
release the checkpoint object that is created from RocksDB
    
    ## Brief change log
    
      -  Use `try() {}` to release the checkpoint object eagerly
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    none


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink release_checkpoint_object

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5682
    
----
commit ec5bf12a884a11d93fda939f7836c1a63a689af6
Author: sihuazhou <summerleafs@...>
Date:   2018-03-12T14:04:57Z

    Use `try () {}` to release Checkpoint object.

----


> Eagerly release the checkpoint object created from RocksDB
> ----------------------------------------------------------
>
>                 Key: FLINK-8927
>                 URL: https://issues.apache.org/jira/browse/FLINK-8927
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should eagerly release the checkpoint object that is created from RocksDB, because
it's a {{RocksObject}} (a native resource).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message