flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)
Date Wed, 14 Mar 2018 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398529#comment-16398529

ASF GitHub Bot commented on FLINK-8910:

Github user StefanRRichter commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java
    @@ -105,6 +105,8 @@ public T createAndRestore(@Nonnull List<? extends Collection<S>>
    +			// IMPORTANT: please be careful when modifying the log statements because they are
used for validation in
    +			// the automatic end-to-end tests. Those tests might fail if they are not aligned
with the log message!
     			if (restoreState.isEmpty()) {
     				LOG.debug("Creating {} with empty state.", logDescription);
     			} else {
    --- End diff --
    I feel that guarding a log statement format by a test, just so that another test won't
fail is a bit too much. I mean, it does not really break anything so a comment should be ok.

> Introduce automated end-to-end test for local recovery (including sticky scheduling)
> ------------------------------------------------------------------------------------
>                 Key: FLINK-8910
>                 URL: https://issues.apache.org/jira/browse/FLINK-8910
>             Project: Flink
>          Issue Type: Test
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>             Fix For: 1.5.0
> We should have an automated end-to-end test that can run nightly to check that sticky
allocation and local recovery work as expected.

This message was sent by Atlassian JIRA

View raw message