flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8890) Compare checkpoints with order in CompletedCheckpoint.checkpointsMatch()
Date Wed, 07 Mar 2018 11:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389423#comment-16389423
] 

ASF GitHub Bot commented on FLINK-8890:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5653#discussion_r172812790
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
    @@ -290,16 +289,14 @@ public static boolean checkpointsMatch(
     		Collection<CompletedCheckpoint> first,
     		Collection<CompletedCheckpoint> second) {
    --- End diff --
    
    Ah, I would've expected that CompletedCheckpoint has an equals method, never mind then.


> Compare checkpoints with order in CompletedCheckpoint.checkpointsMatch()
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8890
>                 URL: https://issues.apache.org/jira/browse/FLINK-8890
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>             Fix For: 1.3.3, 1.5.0, 1.4.2
>
>
> This method is used, among other things, to check if a list of restored checkpoints is
stable after several restore attempts in the ZooKeeper checkpoint store. The order of checkpoints
is somewhat important because we want the latest checkpoint to stay the latest checkpoint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message