flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8873) move unit tests of KeyedStream from DataStreamTest to KeyedStreamTest
Date Wed, 07 Mar 2018 06:48:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389128#comment-16389128
] 

ASF GitHub Bot commented on FLINK-8873:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5649

    [FLINK-8873] [DataStream API] [Tests] move unit tests of KeyedStream from DataStreamTest
to KeyedStreamTest

    ## What is the purpose of the change
    
    move unit tests of `KeyedStream` from `DataStreamTest` to `KeyedStreamTest`, in order
to have a clearer separation
    
    ## Brief change log
    
    added `KeyedStreamTest.java` and `KeyedStreamTest.scala`, and moved related unit tests
to them
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *KeyedStreamTest*.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-8873

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5649
    
----
commit d4e372fbb21edc0507df461aa7f47a9168350a1a
Author: Bowen Li <bowenli86@...>
Date:   2018-03-05T19:52:37Z

    [FLINK-8873] move unit tests of KeyedStream from DataStreamTest to KeyedStreamTest

----


> move unit tests of KeyedStream from DataStreamTest to KeyedStreamTest
> ---------------------------------------------------------------------
>
>                 Key: FLINK-8873
>                 URL: https://issues.apache.org/jira/browse/FLINK-8873
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API, Tests
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.5.0, 1.6.0
>
>
> move unit tests of KeyedStream.scala from DataStreamTest.scala to KeyedStreamTest.scala,
in order to have clearer separation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message