flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8661) Replace Collections.EMPTY_MAP with Collections.emptyMap()
Date Wed, 07 Mar 2018 18:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389898#comment-16389898
] 

ASF GitHub Bot commented on FLINK-8661:
---------------------------------------

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/5659

    [FLINK-8661] [table] Add support for batch queries in SQL Client

    ## What is the purpose of the change
    
    This PR added support for batch queries in SQL Client.
    
    ## Brief change log
    
     - Added a `StaticResult` and a `BatchResult` for the batch query results.
     - Added related methods to `ResultStore` for static results and renamed the existing
methods with a prefix "dynamic".
     - Added the logic for retrieving batch query results consulting to `Dataset.collect()`.
     - Adapted the viewing logic for static results to a "two-phase" table result view.
     - Added the first-page option to `CliTableResultView.java`.
     - Replaced some default values with `""` in `Execution.java`.
    
    ## Verifying this change
    
    This change can be verified by the added test case `testBatchQueryExecution()`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-8861

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5659
    
----
commit 8f21a38dd60ab8c41893ec8c52bfcc47fc54648e
Author: Xingcan Cui <xingcanc@...>
Date:   2018-03-07T17:12:55Z

    [FLINK-8661][table]Add support for batch queries in SQL Client

----


> Replace Collections.EMPTY_MAP with Collections.emptyMap()
> ---------------------------------------------------------
>
>                 Key: FLINK-8661
>                 URL: https://issues.apache.org/jira/browse/FLINK-8661
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes unchecked assignment
and it should be replaced with Collections.emptySet() and Collections.emptyMap() .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message