flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6053) Gauge<T> should only take subclasses of Number, rather than everything
Date Thu, 08 Mar 2018 13:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391225#comment-16391225
] 

ASF GitHub Bot commented on FLINK-6053:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5501#discussion_r173150593
  
    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/metrics/ScalaGauge.scala
---
    @@ -23,6 +23,7 @@ import org.apache.flink.metrics.Gauge
     /**
       * This class allows the concise definition of a gauge from Scala using function references.
       */
    +@deprecated("use NumberGauge or StringGauge instead")
    --- End diff --
    
    Would be good to add a `ScalaStringGauge` and a `ScalaNumericGauge`.


> Gauge<T> should only take subclasses of Number, rather than everything
> ----------------------------------------------------------------------
>
>                 Key: FLINK-6053
>                 URL: https://issues.apache.org/jira/browse/FLINK-6053
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.2.0
>            Reporter: Bowen Li
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.6.0
>
>
> Currently, Flink's Gauge is defined as 
> ```java
> public interface Gauge<T> extends Metric {
> 	T getValue();
> }
> ```
> But it doesn't make sense to have Gauge take generic types other than Number. And it
blocks I from finishing FLINK-6013, because I cannot assume Gauge is only about Number. So
the class should be like
> ```java
> public interface Gauge<T extends Number> extends Metric {
> 	T getValue();
> }
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message