flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4569) JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent thread.
Date Tue, 13 Mar 2018 14:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396968#comment-16396968
] 

ASF GitHub Bot commented on FLINK-4569:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5689#discussion_r174140412
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
    @@ -119,6 +121,11 @@ public void run() {
     		lock.release();
     
     		resumingThread.join();
    +
    +		Throwable exception = error.get();
    +		if (exception != null) {
    +			throw new AssertionError(exception);
    +		}
    --- End diff --
    
    assertNull throws a NPE. This throws the actual exception with stacktrace etc and is the
most equivalent to just throwing the exception.


> JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent thread.
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-4569
>                 URL: https://issues.apache.org/jira/browse/FLINK-4569
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.5.0
>
>
> The mentioned test seems to fail frequently, without being detected, because the Assert.fail()
is called in a separate thread which doesn't forward exceptions.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/156177995/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message