flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yuqi1129 <...@git.apache.org>
Subject [GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...
Date Wed, 28 Mar 2018 12:46:40 GMT
Github user yuqi1129 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5777#discussion_r177736130
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java
---
    @@ -100,9 +102,15 @@ public void run() {
     				writeLock.lock();
     
     				try {
    -					if (!localFile.delete() && localFile.exists()) {
    -						log.warn("Failed to locally delete blob " + localFile.getAbsolutePath());
    -					} else {
    +					try {
    --- End diff --
    
    According to code before, entries will be deleted if no exception occur whether file was
deleted or not. As for you code logic, if We failed to delete file, entries will stay in the
Map. 


---

Mime
View raw message