flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5745: [FLINK-8976] [test] Add end-to-end test for resumi...
Date Fri, 23 Mar 2018 09:30:20 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5745#discussion_r176678588
  
    --- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
    @@ -17,11 +17,25 @@
     # limitations under the License.
     ################################################################################
     
    +if [ -z $1 ] || [ -z $2 ]; then
    +  echo "Usage: ./test_resume_savepoint.sh <original_dop> <new_dop>"
    +  exit 1
    +fi
    +
     source "$(dirname "$0")"/common.sh
     
    -# modify configuration to have 2 slots
    +ORIGINAL_DOP=$1
    +NEW_DOP=$2
    +
    +if (( $ORIGINAL_DOP >= $NEW_DOP )); then
    +  NUM_SLOTS=$(( $ORIGINAL_DOP + 1 ))
    --- End diff --
    
    👌 Yes, it is for the Kafka event generator job.


---

Mime
View raw message