flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...
Date Fri, 23 Mar 2018 08:19:32 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5580#discussion_r176659407
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
    @@ -159,7 +162,7 @@ public ExecutionConfig getConfig() {
     	* Get the list of cached files that were registered for distribution among the task
managers.
     	*/
     	public List<Tuple2<String, DistributedCache.DistributedCacheEntry>> getCachedFiles()
{
    -		return cacheFile;
    +		return cacheFile.entrySet().stream().map(e -> Tuple2.of(e.getKey(), e.getValue())).collect(Collectors.toList());
    --- End diff --
    
    if the mapping is never used there's no value in using a map in the first place.


---

Mime
View raw message