flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5624: [FLINK-8402][s3][tests] fix hadoop/presto S3 IT ca...
Date Tue, 20 Mar 2018 13:51:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5624#discussion_r175770944
  
    --- Diff: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemITCase.java
---
    @@ -143,7 +157,20 @@ public void testDirectoryListing() throws Exception {
     			fs.delete(directory, true);
     		}
     
    -		// now directory must be gone
    -		assertFalse(fs.exists(directory));
    +		// now directory must be gone (this is eventually-consistent, though!)
    +		checkPathExists(fs, directory, false, deadline);
    +	}
    +
    +	private static void checkPathExists(
    --- End diff --
    
    Can we deduplicate this function?


---

Mime
View raw message