flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...
Date Tue, 20 Mar 2018 11:27:51 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175731028
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
---
    @@ -87,17 +89,24 @@ protected static String getResourceFilename(String filename) {
     		return resource.getFile();
     	}
     
    -	@Before
    -	public void setup() throws Exception {
    +	private Configuration getConfigurationSafe() {
    --- End diff --
    
    I think we can get rid of this method by moving the `miniClusterResource` initialization
to the constructor which says that it can throw an `Exception`.


---

Mime
View raw message