flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5672: [FLINK-8872][flip6] fix yarn detached mode command...
Date Tue, 20 Mar 2018 10:50:00 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5672#discussion_r175713202
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
    @@ -97,4 +97,12 @@ default CommandLine parseCommandLineOptions(String[] args, boolean
stopAtNonOpti
     		addRunOptions(options);
     		return CliFrontendParser.parse(options, args, stopAtNonOptions);
     	}
    +
    +	/**
    +	 * Returns whether the call should be detached or not.
    +	 *
    +	 * @param commandLine command line containing options relevant for the detached mode
retrieval
    +	 * @return <tt>true</tt> if it should run detached, <tt>false</tt>
otherwise
    +	 */
    +	boolean isDetachedMode(CommandLine commandLine);
    --- End diff --
    
    See comment above.


---

Mime
View raw message