flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #5710: [FLINK-8948][runtime] Fix IllegalStateException wh...
Date Mon, 19 Mar 2018 11:36:02 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5710#discussion_r175404351
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java
---
    @@ -99,10 +99,11 @@ public void commit() {
     	 * Mark this {@link BufferBuilder} and associated {@link BufferConsumer} as finished
- no new data writes will be
     	 * allowed.
     	 *
    +	 * <p>This method should be idempotent to handle failures and task interruptions.
Check FLINK-8948 for more details.
    +	 *
     	 * @return number of written bytes.
     	 */
     	public int finish() {
    -		checkState(!isFinished());
    --- End diff --
    
    almost...except for finishing an empty buffer twice ;)


---

Mime
View raw message