flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #5521: [FLINK-8599] Improve the failure behavior of the F...
Date Fri, 09 Mar 2018 13:53:16 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5521#discussion_r173453379
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
    @@ -340,6 +341,10 @@ public void run() {
     					}
     				}
     
    +			} catch (FileNotFoundException e) {
    +				if (LOG.isDebugEnabled()) {
    --- End diff --
    
    This needs to be more prominently logged than `debug`. Should be at least `info` or `warn`.
    
    Please also use the placeholder syntax from log4j, to make the code simpler.


---

Mime
View raw message