flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5653: [FLINK-8890] Compare checkpoints with order in Com...
Date Wed, 07 Mar 2018 11:12:26 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5653#discussion_r172807512
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
    @@ -290,16 +289,14 @@ public static boolean checkpointsMatch(
     		Collection<CompletedCheckpoint> first,
     		Collection<CompletedCheckpoint> second) {
     
    -		Set<Tuple2<Long, JobID>> firstInterestingFields =
    -			new HashSet<>();
    +		List<Tuple2<Long, JobID>> firstInterestingFields = new ArrayList<>();
     
     		for (CompletedCheckpoint checkpoint : first) {
     			firstInterestingFields.add(
     				new Tuple2<>(checkpoint.getCheckpointID(), checkpoint.getJobId()));
     		}
     
    -		Set<Tuple2<Long, JobID>> secondInterestingFields =
    -			new HashSet<>();
    +		List<Tuple2<Long, JobID>> secondInterestingFields = new ArrayList<>();
    --- End diff --
    
    initialize with `second.size()`


---

Mime
View raw message