From issues-return-156076-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Feb 28 12:02:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 872BE180657 for ; Wed, 28 Feb 2018 12:02:08 +0100 (CET) Received: (qmail 11712 invoked by uid 500); 28 Feb 2018 11:02:07 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 11703 invoked by uid 99); 28 Feb 2018 11:02:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2018 11:02:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 114B1C1F1B for ; Wed, 28 Feb 2018 11:02:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 93twwK2imlQO for ; Wed, 28 Feb 2018 11:02:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 633E45FBBA for ; Wed, 28 Feb 2018 11:02:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8DBF9E0955 for ; Wed, 28 Feb 2018 11:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C8AB824147 for ; Wed, 28 Feb 2018 11:02:00 +0000 (UTC) Date: Wed, 28 Feb 2018 11:02:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8778) Migrate queryable state ITCases to use MiniClusterResource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8778?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1638= 0130#comment-16380130 ]=20 ASF GitHub Bot commented on FLINK-8778: --------------------------------------- Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r171209553 =20 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/= java/org/apache/flink/queryablestate/itcases/HAQueryableStateFsBackendITCas= e.java --- @@ -18,28 +18,99 @@ =20 package org.apache.flink.queryablestate.itcases; =20 +import org.apache.flink.configuration.ConfigConstants; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.HighAvailabilityOptions; +import org.apache.flink.configuration.QueryableStateOptions; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.configuration.WebOptions; +import org.apache.flink.queryablestate.client.QueryableStateClient; import org.apache.flink.runtime.state.AbstractStateBackend; import org.apache.flink.runtime.state.filesystem.FsStateBackend; +import org.apache.flink.test.util.MiniClusterResource; =20 +import org.apache.curator.test.TestingServer; +import org.junit.AfterClass; import org.junit.BeforeClass; -import org.junit.Rule; +import org.junit.ClassRule; import org.junit.rules.TemporaryFolder; =20 /** * Several integration tests for queryable state using the {@link FsSt= ateBackend}. */ -public class HAQueryableStateFsBackendITCase extends HAAbstractQueryab= leStateTestBase { +public class HAQueryableStateFsBackendITCase extends AbstractQueryable= StateTestBase { --- End diff -- =20 I tend to agree. I created an updated version of this here: #5595 It's = still using inheritance but I changed it such that the base class now alway= s calls `setDetached(true)`. I don't want to go into refactoring those test= s now because there is already enough to do. Plus, I did remove one layer o= f inheritance. =F0=9F=98=85=20 > Migrate queryable state ITCases to use MiniClusterResource > ---------------------------------------------------------- > > Key: FLINK-8778 > URL: https://issues.apache.org/jira/browse/FLINK-8778 > Project: Flink > Issue Type: Sub-task > Components: Tests > Reporter: Aljoscha Krettek > Assignee: Aljoscha Krettek > Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)