From issues-return-151713-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Feb 9 16:09:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 80C45180654 for ; Fri, 9 Feb 2018 16:09:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 70901160C4C; Fri, 9 Feb 2018 15:09:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3646160C2E for ; Fri, 9 Feb 2018 16:09:05 +0100 (CET) Received: (qmail 75565 invoked by uid 500); 9 Feb 2018 15:09:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 75556 invoked by uid 99); 9 Feb 2018 15:09:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 15:09:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5AF0D180119 for ; Fri, 9 Feb 2018 15:09:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Qg9xfXmwi9KG for ; Fri, 9 Feb 2018 15:09:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 71AD05FB58 for ; Fri, 9 Feb 2018 15:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AFF39E0161 for ; Fri, 9 Feb 2018 15:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 209D521E85 for ; Fri, 9 Feb 2018 15:09:00 +0000 (UTC) Date: Fri, 9 Feb 2018 15:09:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8626) Introduce BackPressureStatsTracker interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358509#comment-16358509 ] ASF GitHub Bot commented on FLINK-8626: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5443 [FLINK-8626] Introduce BackPressureStatsTracker interface ## What is the purpose of the change Renames BackPressureStatsTracker into BackPressureStatsTrackerImpl and introduce a BackPressureStatsTracker interface. This will make testing easier when we don't have to set up all the different components. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink introduceBackPressureStatsTrackerInterface Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5443.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5443 ---- commit 8e172aee75e9e0c81608ed7e6796bca1ea7d7544 Author: Till Rohrmann Date: 2018-02-09T13:07:31Z [FLINK-8626] Introduce BackPressureStatsTracker interface Renames BackPressureStatsTracker into BackPressureStatsTrackerImpl and introduce a BackPressureStatsTracker interface. This will make testing easier when we don't have to set up all the different components. ---- > Introduce BackPressureStatsTracker interface > -------------------------------------------- > > Key: FLINK-8626 > URL: https://issues.apache.org/jira/browse/FLINK-8626 > Project: Flink > Issue Type: Improvement > Components: REST, Tests > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > Fix For: 1.5.0 > > > In order to better test components like the {{JobMaster}} we should introduce a {{BackPressureStatsTracker}} interface and rename the current {{BackPressureStatsTracker}} class into {{BackPressureStatsTrackerImpl}}. This will simplify testing where we have to set up all these things. -- This message was sent by Atlassian JIRA (v7.6.3#76005)