From issues-return-151314-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Feb 6 22:29:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 0B25C180657 for ; Tue, 6 Feb 2018 22:29:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EDD0D160C46; Tue, 6 Feb 2018 21:29:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3F6A2160C37 for ; Tue, 6 Feb 2018 22:29:04 +0100 (CET) Received: (qmail 146 invoked by uid 500); 6 Feb 2018 21:29:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 137 invoked by uid 99); 6 Feb 2018 21:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2018 21:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D50E3C0042 for ; Tue, 6 Feb 2018 21:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2Pfc4Ieik7oC for ; Tue, 6 Feb 2018 21:29:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 825F15F181 for ; Tue, 6 Feb 2018 21:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DE414E0257 for ; Tue, 6 Feb 2018 21:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 766BA21E84 for ; Tue, 6 Feb 2018 21:29:00 +0000 (UTC) Date: Tue, 6 Feb 2018 21:29:00 +0000 (UTC) From: "Chesnay Schepler (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (FLINK-8559) Exceptions in RocksDBIncrementalSnapshotOperation#takeSnapshot cause job to get stuck MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8559?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8559. ----------------------------------- Resolution: Fixed master: dbb81acb5a1d0f2a9521c6eef7eeb2436bb8004d > Exceptions in RocksDBIncrementalSnapshotOperation#takeSnapshot cause job = to get stuck > -------------------------------------------------------------------------= ------------ > > Key: FLINK-8559 > URL: https://issues.apache.org/jira/browse/FLINK-8559 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing, Tests > Affects Versions: 1.4.0, 1.5.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Blocker > Fix For: 1.5.0, 1.4.1 > > > In the {{RocksDBKeyedStatebackend#snapshotIncrementally}} we can find thi= s code > =C2=A0 > {code:java} > final RocksDBIncrementalSnapshotOperation snapshotOperation =3D > =09new RocksDBIncrementalSnapshotOperation<>( > =09=09this, > =09=09checkpointStreamFactory, > =09=09checkpointId, > =09=09checkpointTimestamp); > snapshotOperation.takeSnapshot(); > return new FutureTask( > =09new Callable() { > =09=09@Override > =09=09public KeyedStateHandle call() throws Exception { > =09=09=09return snapshotOperation.materializeSnapshot(); > =09=09} > =09} > ) { > =09@Override > =09public boolean cancel(boolean mayInterruptIfRunning) { > =09=09snapshotOperation.stop(); > =09=09return super.cancel(mayInterruptIfRunning); > =09} > =09@Override > =09protected void done() { > =09=09snapshotOperation.releaseResources(isCancelled()); > =09} > }; > {code} > In the constructor of RocksDBIncrementalSnapshotOperation we call {{aquir= eResource()}} on the RocksDB {{ResourceGuard}}. If {{snapshotOperation.take= Snapshot()}} fails with an exception these resources are never released. Wh= en the task is shutdown due to the exception it will get stuck on releasing= RocksDB. -- This message was sent by Atlassian JIRA (v7.6.3#76005)