From issues-return-155519-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Feb 26 16:09:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0853018077B for ; Mon, 26 Feb 2018 16:09:06 +0100 (CET) Received: (qmail 12169 invoked by uid 500); 26 Feb 2018 15:09:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 12160 invoked by uid 99); 26 Feb 2018 15:09:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2018 15:09:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8579CC605E for ; Mon, 26 Feb 2018 15:09:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id aZ4kRppa1Okp for ; Mon, 26 Feb 2018 15:09:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 761F85FC52 for ; Mon, 26 Feb 2018 15:09:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9DD7FE0A5D for ; Mon, 26 Feb 2018 15:09:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 577B3255EB for ; Mon, 26 Feb 2018 15:09:01 +0000 (UTC) Date: Mon, 26 Feb 2018 15:09:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8428) Implement stream-stream non-window left outer join MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8428?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1637= 7011#comment-16377011 ]=20 ASF GitHub Bot commented on FLINK-8428: --------------------------------------- Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170296184 =20 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/t= able/plan/util/UpdatingPlanChecker.scala --- @@ -149,45 +148,39 @@ object UpdatingPlanChecker { } =20 case j: DataStreamJoin =3D> - val joinType =3D j.getJoinType - joinType match { - case JoinRelType.INNER =3D> - // get key(s) for inner join - val lInKeys =3D visit(j.getLeft) - val rInKeys =3D visit(j.getRight) - if (lInKeys.isEmpty || rInKeys.isEmpty) { - None - } else { - // Output of inner join must have keys if left and rig= ht both contain key(s). - // Key groups from both side will be merged by join eq= ui-predicates - val lInNames: Seq[String] =3D j.getLeft.getRowType.get= FieldNames - val rInNames: Seq[String] =3D j.getRight.getRowType.ge= tFieldNames - val joinNames =3D j.getRowType.getFieldNames - - // if right field names equal to left field names, cal= cite will rename right - // field names. For example, T1(pk, a) join T2(pk, b),= calcite will rename T2(pk, b) - // to T2(pk0, b). - val rInNamesToJoinNamesMap =3D rInNames - .zip(joinNames.subList(lInNames.size, joinNames.leng= th)) - .toMap + // get key(s) for inner join + val lInKeys =3D visit(j.getLeft) + val rInKeys =3D visit(j.getRight) + if (lInKeys.isEmpty || rInKeys.isEmpty) { + None + } else { + // Output of inner join must have keys if left and right b= oth contain key(s). --- End diff -- =20 remove "inner"? > Implement stream-stream non-window left outer join > -------------------------------------------------- > > Key: FLINK-8428 > URL: https://issues.apache.org/jira/browse/FLINK-8428 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: Hequn Cheng > Assignee: Hequn Cheng > Priority: Major > > Implement stream-stream non-window left outer join for sql/table-api. A s= imple design doc can be found=C2=A0[here|https://docs.google.com/document/d= /1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=3Dsharing] -- This message was sent by Atlassian JIRA (v7.6.3#76005)