From issues-return-151794-archive-asf-public=cust-asf.ponee.io@flink.apache.org Sat Feb 10 11:35:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 2766218061A for ; Sat, 10 Feb 2018 11:35:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 17435160C4D; Sat, 10 Feb 2018 10:35:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D20F160C30 for ; Sat, 10 Feb 2018 11:35:04 +0100 (CET) Received: (qmail 41824 invoked by uid 500); 10 Feb 2018 10:35:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 41815 invoked by uid 99); 10 Feb 2018 10:35:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Feb 2018 10:35:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 046F5C0F4C for ; Sat, 10 Feb 2018 10:35:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 06pUDs3VCRmV for ; Sat, 10 Feb 2018 10:35:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 43F645F16A for ; Sat, 10 Feb 2018 10:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7022CE0047 for ; Sat, 10 Feb 2018 10:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3236E21E84 for ; Sat, 10 Feb 2018 10:35:00 +0000 (UTC) Date: Sat, 10 Feb 2018 10:35:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8423) OperatorChain#pushToOperator catch block may fail with NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359363#comment-16359363 ] ASF GitHub Bot commented on FLINK-8423: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5447#discussion_r167395295 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -591,16 +591,18 @@ public void collect(StreamRecord record) { operator.setKeyContextElement1(copy); operator.processElement(copy); } catch (ClassCastException e) { - // Enrich error message - ClassCastException replace = new ClassCastException( - String.format( - "%s. Failed to push OutputTag with id '%s' to operator. " + - "This can occur when multiple OutputTags with different types " + - "but identical names are being used.", - e.getMessage(), - outputTag.getId())); - - throw new ExceptionInChainedOperatorException(replace); + if (outputTag != null) { --- End diff -- Neither. just add an else block that re-throws the original exception. > OperatorChain#pushToOperator catch block may fail with NPE > ---------------------------------------------------------- > > Key: FLINK-8423 > URL: https://issues.apache.org/jira/browse/FLINK-8423 > Project: Flink > Issue Type: Bug > Components: Streaming > Affects Versions: 1.4.0, 1.5.0 > Reporter: Chesnay Schepler > Assignee: mingleizhang > Priority: Critical > > {code} > @Override > protected void pushToOperator(StreamRecord record) { > try { > // we know that the given outputTag matches our OutputTag so the record > // must be of the type that our operator (and Serializer) expects. > @SuppressWarnings("unchecked") > StreamRecord castRecord = (StreamRecord) record; > numRecordsIn.inc(); > StreamRecord copy = castRecord.copy(serializer.copy(castRecord.getValue())); > operator.setKeyContextElement1(copy); > operator.processElement(copy); > } catch (ClassCastException e) { > // Enrich error message > ClassCastException replace = new ClassCastException( > String.format( > "%s. Failed to push OutputTag with id '%s' to operator. " + > "This can occur when multiple OutputTags with different types " + > "but identical names are being used.", > e.getMessage(), > outputTag.getId())); > throw new ExceptionInChainedOperatorException(replace); > } catch (Exception e) { > throw new ExceptionInChainedOperatorException(e); > } > } > {code} > If outputTag is null (as is the case when no sideOutput was defined) the catch block will crash with a NullPointerException. This may happen if {{operator.processElement}} throws a ClassCastException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)