From issues-return-150653-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Feb 1 13:21:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D3EAC180652 for ; Thu, 1 Feb 2018 13:21:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3D8E160C44; Thu, 1 Feb 2018 12:21:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 17E87160C26 for ; Thu, 1 Feb 2018 13:21:06 +0100 (CET) Received: (qmail 87871 invoked by uid 500); 1 Feb 2018 12:21:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 87705 invoked by uid 99); 1 Feb 2018 12:21:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 12:21:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F247AC3E68 for ; Thu, 1 Feb 2018 12:21:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vOWxP1bYgy5K for ; Thu, 1 Feb 2018 12:21:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 351615FB89 for ; Thu, 1 Feb 2018 12:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 614BFE0144 for ; Thu, 1 Feb 2018 12:21:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 22C6321E81 for ; Thu, 1 Feb 2018 12:21:00 +0000 (UTC) Date: Thu, 1 Feb 2018 12:21:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8360) Implement task-local state recovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348495#comment-16348495 ] ASF GitHub Bot commented on FLINK-8360: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r165340438 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java --- @@ -501,4 +529,53 @@ public String toString() { "', asynchronous: " + asynchronousSnapshots + ", fileStateThreshold: " + fileStateThreshold + ")"; } + + /** + * This enum represents the different modes for local recovery. + */ + public enum LocalRecoveryMode { + DISABLED, ENABLE_FILE_BASED, ENABLE_HEAP_BASED + } + + /** + * This class encapsulates the configuration for local recovery of this backend. + */ + public static final class LocalRecoveryConfig implements Serializable { + + private static final long serialVersionUID = 1L; + private static final LocalRecoveryConfig DISABLED_SINGLETON = + new LocalRecoveryConfig(LocalRecoveryMode.DISABLED, null); + + private final LocalRecoveryMode localRecoveryMode; + private final File localStateDirectory; + + LocalRecoveryConfig(LocalRecoveryMode localRecoveryMode, File localStateDirectory) { + this.localRecoveryMode = Preconditions.checkNotNull(localRecoveryMode); + this.localStateDirectory = localStateDirectory; + if (LocalRecoveryMode.ENABLE_FILE_BASED.equals(localRecoveryMode) && localStateDirectory == null) { + throw new IllegalStateException("Local state directory must be specified if local recovery mode is " + + LocalRecoveryMode.ENABLE_FILE_BASED); + } + } + + public LocalRecoveryMode getLocalRecoveryMode() { + return localRecoveryMode; + } + + public File getLocalStateDirectory() { + return localStateDirectory; --- End diff -- How does this play together with `ENABLE_HEAP_BASED` `LocalRecoveryMode`? > Implement task-local state recovery > ----------------------------------- > > Key: FLINK-8360 > URL: https://issues.apache.org/jira/browse/FLINK-8360 > Project: Flink > Issue Type: New Feature > Components: State Backends, Checkpointing > Reporter: Stefan Richter > Assignee: Stefan Richter > Priority: Major > Fix For: 1.5.0 > > > This issue tracks the development of recovery from task-local state. The main idea is to have a secondary, local copy of the checkpointed state, while there is still a primary copy in DFS that we report to the checkpoint coordinator. > Recovery can attempt to restore from the secondary local copy, if available, to save network bandwidth. This requires that the assignment from tasks to slots is as sticky is possible. > For starters, we will implement this feature for all managed keyed states and can easily enhance it to all other state types (e.g. operator state) later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)