From issues-return-155940-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Feb 27 18:34:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6BA8B180671 for ; Tue, 27 Feb 2018 18:34:54 +0100 (CET) Received: (qmail 33917 invoked by uid 500); 27 Feb 2018 17:34:53 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 33900 invoked by uid 99); 27 Feb 2018 17:34:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 17:34:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1BA63F4E13; Tue, 27 Feb 2018 17:34:53 +0000 (UTC) From: NicoK To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema... Content-Type: text/plain Message-Id: <20180227173453.1BA63F4E13@git1-us-west.apache.org> Date: Tue, 27 Feb 2018 17:34:53 +0000 (UTC) Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171000868 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializer.java --- @@ -107,10 +107,9 @@ else if (eventClass == CancelCheckpointMarker.class) { * * @param buffer the buffer to peak into * @param eventClass the expected class of the event type - * @param classLoader the class loader to use for custom event classes * @return whether the event class of the buffer matches the given eventClass */ - private static boolean isEvent(ByteBuffer buffer, Class eventClass, ClassLoader classLoader) throws IOException { + private static boolean isEvent(ByteBuffer buffer, Class eventClass) throws IOException { --- End diff -- this change qualifies for a separate JIRA ticket, not just a hotfix ---