From issues-return-154348-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Feb 21 15:50:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF56418061A for ; Wed, 21 Feb 2018 15:50:04 +0100 (CET) Received: (qmail 1838 invoked by uid 500); 21 Feb 2018 14:50:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 1829 invoked by uid 99); 21 Feb 2018 14:50:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 14:50:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 43840DFC3E; Wed, 21 Feb 2018 14:50:01 +0000 (UTC) From: StephanEwen To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs... Content-Type: text/plain Message-Id: <20180221145002.43840DFC3E@git1-us-west.apache.org> Date: Wed, 21 Feb 2018 14:50:01 +0000 (UTC) Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5544 Good change in principle, but I think "base" and "append" are not a great choice of names for the parameters. Probably not very intuitive for users. How about calling them `default` and `additional`? While at it, should we also rename the `ALWAYS_PARENT_FIRST_LOADER` config key name? Calling it `CLASS_LOADING_PARENT_FIRST_PACKAGES` or `CL_PARENT_FIRST_PATTERNS` seems better. ---