From issues-return-152902-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Feb 14 19:22:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 10C63180621 for ; Wed, 14 Feb 2018 19:22:17 +0100 (CET) Received: (qmail 80913 invoked by uid 500); 14 Feb 2018 18:22:17 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 80904 invoked by uid 99); 14 Feb 2018 18:22:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 18:22:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 097E5DFE46; Wed, 14 Feb 2018 18:22:17 +0000 (UTC) From: bowenli86 To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF... Content-Type: text/plain Message-Id: <20180214182217.097E5DFE46@git1-us-west.apache.org> Date: Wed, 14 Feb 2018 18:22:17 +0000 (UTC) Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r168265503 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -162,7 +162,7 @@ class GroupAggProcessFunction( override def onTimer( timestamp: Long, - ctx: ProcessFunction[CRow, CRow]#OnTimerContext, + ctx: ProcessFunction[CRow, CRow]#OnTimerContext[_], --- End diff -- yes, I think I'll create a `KeyedProcessFunction` as Aljoscha suggested, and we probably don't need these scala changes any more. ---