From issues-return-152366-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Feb 13 16:53:31 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ADC4118072F for ; Tue, 13 Feb 2018 16:53:29 +0100 (CET) Received: (qmail 39673 invoked by uid 500); 13 Feb 2018 15:53:27 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 39475 invoked by uid 99); 13 Feb 2018 15:53:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 15:53:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5C3DDE08A1; Tue, 13 Feb 2018 15:53:27 +0000 (UTC) From: StefanRRichter To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5423: [FLINK-8581] Improve performance for low latency n... Content-Type: text/plain Message-Id: <20180213155327.5C3DDE08A1@git1-us-west.apache.org> Date: Tue, 13 Feb 2018 15:53:27 +0000 (UTC) Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5423#discussion_r167621132 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java --- @@ -60,12 +60,20 @@ void tagAsEvent(); /** - * Returns the underlying memory segment. + * Returns the underlying memory segment. This method is dangerous since it ignores read only protections and omits + * slices. Use it only along the {@link #getMemorySegmentOffset()}. * * @return the memory segment backing this buffer */ + @Deprecated --- End diff -- You should name the proper replacement for this deprecated method in the comment, or say that it will be eventually removed without replacement. ---