From issues-return-152353-archive-asf-public=cust-asf.ponee.io@flink.apache.org  Tue Feb 13 16:53:28 2018
Return-Path: <issues-return-152353-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 3820018067B
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 13 Feb 2018 16:53:28 +0100 (CET)
Received: (qmail 38554 invoked by uid 500); 13 Feb 2018 15:53:27 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 38525 invoked by uid 99); 13 Feb 2018 15:53:27 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 15:53:27 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1FE06DFAE1; Tue, 13 Feb 2018 15:53:26 +0000 (UTC)
From: StefanRRichter <git@git.apache.org>
To: issues@flink.apache.org
Reply-To: issues@flink.apache.org
References: <git-pr-5423-flink@git.apache.org>
In-Reply-To: <git-pr-5423-flink@git.apache.org>
Subject: [GitHub] flink pull request #5423: [FLINK-8581] Improve performance for low latency n...
Content-Type: text/plain
Message-Id: <20180213155326.1FE06DFAE1@git1-us-west.apache.org>
Date: Tue, 13 Feb 2018 15:53:26 +0000 (UTC)

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r167596726
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ---
    @@ -131,9 +114,9 @@ public void release() {
     			}
     
     			// Release all available buffers
    -			Buffer buffer;
    -			while ((buffer = buffers.poll()) != null) {
    -				buffer.recycleBuffer();
    +			BufferConsumer bufferConsumer;
    +			while ((bufferConsumer = buffers.poll()) != null) {
    --- End diff --
    
    Maybe this part of the `release()`method should also go into the superclass, which usually manages `buffers`. The method could also have an optional hook for additional cleanups inside the `synchronized` block that subclasses can use if needed.


---