flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8778) Migrate queryable state ITCases to use MiniClusterResource
Date Wed, 28 Feb 2018 11:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380178#comment-16380178
] 

ASF GitHub Bot commented on FLINK-8778:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5595#discussion_r171221624
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
---
    @@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration() {
     	 * @param jobGraph The JobGraph to be submitted
     	 * @return JobSubmissionResult
     	 */
    -	protected abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
    +	public abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
    --- End diff --
    
    well...i guess wrong usages will be catched by the tests....


> Migrate queryable state ITCases to use MiniClusterResource
> ----------------------------------------------------------
>
>                 Key: FLINK-8778
>                 URL: https://issues.apache.org/jira/browse/FLINK-8778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message