flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8778) Migrate queryable state ITCases to use MiniClusterResource
Date Wed, 28 Feb 2018 11:02:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380130#comment-16380130

ASF GitHub Bot commented on FLINK-8778:

Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAQueryableStateFsBackendITCase.java
    @@ -18,28 +18,99 @@
     package org.apache.flink.queryablestate.itcases;
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.HighAvailabilityOptions;
    +import org.apache.flink.configuration.QueryableStateOptions;
    +import org.apache.flink.configuration.TaskManagerOptions;
    +import org.apache.flink.configuration.WebOptions;
    +import org.apache.flink.queryablestate.client.QueryableStateClient;
     import org.apache.flink.runtime.state.AbstractStateBackend;
     import org.apache.flink.runtime.state.filesystem.FsStateBackend;
    +import org.apache.flink.test.util.MiniClusterResource;
    +import org.apache.curator.test.TestingServer;
    +import org.junit.AfterClass;
     import org.junit.BeforeClass;
    -import org.junit.Rule;
    +import org.junit.ClassRule;
     import org.junit.rules.TemporaryFolder;
      * Several integration tests for queryable state using the {@link FsStateBackend}.
    -public class HAQueryableStateFsBackendITCase extends HAAbstractQueryableStateTestBase
    +public class HAQueryableStateFsBackendITCase extends AbstractQueryableStateTestBase {
    --- End diff --
    I tend to agree. I created an updated version of this here: #5595 It's still using inheritance
but I changed it such that the base class now always calls `setDetached(true)`. I don't want
to go into refactoring those tests now because there is already enough to do. Plus, I did
remove one layer of inheritance. 😅 

> Migrate queryable state ITCases to use MiniClusterResource
> ----------------------------------------------------------
>                 Key: FLINK-8778
>                 URL: https://issues.apache.org/jira/browse/FLINK-8778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0

This message was sent by Atlassian JIRA

View raw message