flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8777) improve resource release when recovery from failover
Date Wed, 28 Feb 2018 09:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379983#comment-16379983
] 

ASF GitHub Bot commented on FLINK-8777:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5578#discussion_r171177343
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java
---
    @@ -300,6 +295,34 @@ private void deleteDirectory(File directory) throws IOException {
     		}
     	}
     
    +	/**
    +	 * Pruning the useless checkpoints, it should be called only when holding the {@link
#lock}.
    +	 */
    +	private void pruneCheckpoints(Predicate<Long> pruningChecker, boolean breakOnceCheckerFalse)
{
    --- End diff --
    
    We can use `LongPredicate` instead of `Predicate<Long>`


> improve resource release when recovery from failover
> ----------------------------------------------------
>
>                 Key: FLINK-8777
>                 URL: https://issues.apache.org/jira/browse/FLINK-8777
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> When recovery from failed, {{TaskLocalStateStoreImpl.retrieveLocalState()}} will be invoked,
we can release all entry from {{storedTaskStateByCheckpointID}}  that does not satisfy {{entry.checkpointID
== checkpointID}}, this can prevent the resource leak when job loop in {{local checkpoint
completed => failed => local checkpoint completed => failed ...}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message