flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts
Date Fri, 23 Feb 2018 19:53:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374906#comment-16374906
] 

ASF GitHub Bot commented on FLINK-8761:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5569#discussion_r170351448
  
    --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
---
    @@ -50,181 +51,113 @@ under the License.
     		</repository>
     	</repositories>
     
    -	<!-- 
    -
    -		Execute "mvn clean package -Pbuild-jar"
    -		to build a jar file out of this project!
    -
    -		How to use the Flink Quickstart pom:
    -
    -		a) Adding new dependencies:
    -			You can add dependencies to the list below.
    -
    -		b) Build a jar for running on the cluster:
    -
    -			"mvn clean package -Pbuild-jar"
    -			This will create a fat-jar which contains all dependencies necessary for running the
created jar in a cluster.
    -	-->
    -
     	<dependencies>
     		<!-- Apache Flink dependencies -->
    -		<dependency>
    -			<groupId>org.apache.flink</groupId>
    -			<artifactId>flink-core</artifactId>
    -			<version>${flink.version}</version>
    -		</dependency>
    +		<!-- These dependencies are provided, because they should not be packaged into the
JAR file. -->
     		<dependency>
     			<groupId>org.apache.flink</groupId>
     			<artifactId>flink-java</artifactId>
     			<version>${flink.version}</version>
    +			<scope>provided</scope>
     		</dependency>
     		<dependency>
    -			<!-- This dependency is required to actually execute jobs. It is currently pulled
in by
    -				flink-streaming-java, but we explicitly depend on it to safeguard against future
changes. -->
     			<groupId>org.apache.flink</groupId>
    -			<artifactId>flink-clients_${scala.binary.version}</artifactId>
    +			<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
     			<version>${flink.version}</version>
    +			<scope>provided</scope>
     		</dependency>
    +
    +		<!-- Add connector dependencies here. They must be in the default scope (compile).
-->
    +
    +		<!-- Example:
    +
     		<dependency>
     			<groupId>org.apache.flink</groupId>
    -			<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
    +			<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
    --- End diff --
    
    Interesting - in my setup, dependency convergence is not activated by default. Did you
explicitly activate it?


> Various improvements to the Quickstarts
> ---------------------------------------
>
>                 Key: FLINK-8761
>                 URL: https://issues.apache.org/jira/browse/FLINK-8761
>             Project: Flink
>          Issue Type: Improvement
>          Components: Quickstarts
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Various improvements to the Quickstarts to give a smoother out of the box experience.
> Broken down into the subtasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message