flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8741) KafkaFetcher09/010/011 uses wrong user code classloader
Date Mon, 26 Feb 2018 11:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376682#comment-16376682
] 

ASF GitHub Bot commented on FLINK-8741:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5568
  
    @aljoscha I've made a few extra changes, and made sure that the end-to-end test fails
properly without the fix:
    - use the correct data formats in the Kafka e2e test
    - allows the e2e test to print error logs (in this case, the logs would have a `ClassNotFoundException:
CustomWatermarkAssigner` without this PR's fix) in case of a timeout interruption. This should
improve visibility in a failure scenario.
    
    Could you have another last look?


> KafkaFetcher09/010/011 uses wrong user code classloader
> -------------------------------------------------------
>
>                 Key: FLINK-8741
>                 URL: https://issues.apache.org/jira/browse/FLINK-8741
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.5.0, 1.4.1
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.2
>
>
> This commit https://github.com/apache/flink/commit/0a1ce0060ef3af29b196ab6ad58f97e49a40a4cf#diff-51fb939365cf758a89794a2599344702R98 caused
the wrong classloader to be used.
> The user code classloader should be used directly, not its parent. That change seems
to be irrelevant to the issue, and seems to have been changed by accident.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message