flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8679) RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with namespace
Date Mon, 19 Feb 2018 13:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369127#comment-16369127
] 

ASF GitHub Bot commented on FLINK-8679:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5518#discussion_r169066387
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
---
    @@ -62,7 +62,7 @@
     	 * @param state State variable for which existing keys will be returned.
     	 * @param namespace Namespace for which existing keys will be returned.
     	 */
    -	<N> Stream<K> getKeys(String state, N namespace);
    +	<N> Stream<K> getKeys(String state, N namespace, TypeSerializer<N>
namespaceSerializer);
    --- End diff --
    
    New parameter should be referenced in JavaDoc.


> RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with namespace
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-8679
>                 URL: https://issues.apache.org/jira/browse/FLINK-8679
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Currently, `RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It doesn't use
the namespace to filter data. And `HeapKeyedBackend.getKeys(stateName, namespace)` has done
that, I think they should be consistent at least.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message