flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8675) Make shut down of RestServerEndpoint non blocking
Date Fri, 16 Feb 2018 17:30:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367618#comment-16367618

ASF GitHub Bot commented on FLINK-8675:

GitHub user tillrohrmann opened a pull request:


    [FLINK-8675] Add non-blocking shut down method to RestServerEndpoint

    ## What is the purpose of the change
    Make shut down method of RestServerEndpoint non blocking.
    This PR is based on #5503.
    ## Verifying this change
    This change is already covered by existing tests, such as `RestServerEndpointITCase`.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink nonBlockingRestEndpointShutDown

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5511
commit 51bb532d2490968635214016599475f91c5f97e5
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-16T09:08:04Z

    [FLINK-8669] Add completeAll and runAfterwards(Async) to FutureUtils
    FutureUtils#completeAll(Collection) takes a collection of futures and returns
    a future which is completed after all of the given futures are completed. This
    also includes exceptional completions. Potentially occurring exceptions are
    recorded and combined into a single exception with which the resulting future
    is completed.
    FutureUtils#runAfterwards takes a future and runs a given action after the
    completion of the given future. This also includes an exceptional completion.
    In this case, a potentially occurring exception as the result of the provided
    action will be combined with the future's exception.

commit 25b8893a21c5f3d215bf0bf3dea76ef6a46e612d
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-16T17:01:58Z

    [FLINK-8675] Add non-blocking shut down method to RestServerEndpoint
    Make shut down method of RestServerEndpoint non blocking.


> Make shut down of RestServerEndpoint non blocking
> -------------------------------------------------
>                 Key: FLINK-8675
>                 URL: https://issues.apache.org/jira/browse/FLINK-8675
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.5.0
> In order to better shut down different components, it would be helpful if the {{RestServerEndpoint}}
would not block when being shut down.

This message was sent by Atlassian JIRA

View raw message