flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()
Date Fri, 16 Feb 2018 19:56:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367802#comment-16367802
] 

ASF GitHub Bot commented on FLINK-8667:
---------------------------------------

Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5500#discussion_r168855562
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java
---
    @@ -324,6 +324,11 @@ public TimeDomain timeDomain() {
     			return timeDomain;
     		}
     
    +		@Override
    +		public KS getCurrentKey() {
    --- End diff --
    
    added


> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>
>                 Key: FLINK-8667
>                 URL: https://issues.apache.org/jira/browse/FLINK-8667
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>
> [~aljoscha] [~pnowojski]  
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think it will
be great to expose the timer's key in KeyedBroadcastProcessFunction too. If we don't do it
now, it will be much more difficult to add the feature on later because of user app compatibility
issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message