flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8630) To support JSON schema to TypeInformation conversion
Date Thu, 15 Feb 2018 12:10:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365445#comment-16365445
] 

ASF GitHub Bot commented on FLINK-8630:
---------------------------------------

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5491#discussion_r168438157
  
    --- Diff: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonNodeDeserializationSchema.java
---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.formats.json;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.serialization.AbstractDeserializationSchema;
    +
    +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.node.ObjectNode;
    +
    +import java.io.IOException;
    +
    +/**
    + * DeserializationSchema that deserializes a JSON String into an ObjectNode.
    + *
    + * <p>Fields can be accessed by calling objectNode.get(&lt;name>).as(&lt;type>)
    + */
    +@PublicEvolving
    +public class JsonNodeDeserializationSchema extends AbstractDeserializationSchema<ObjectNode>
{
    +
    +	private static final long serialVersionUID = -1699854177598621044L;
    +
    +	private ObjectMapper mapper;
    +
    +	@Override
    +	public ObjectNode deserialize(byte[] message) throws IOException {
    --- End diff --
    
    IMO, this method should be thread-safe.


> To support JSON schema to TypeInformation conversion 
> -----------------------------------------------------
>
>                 Key: FLINK-8630
>                 URL: https://issues.apache.org/jira/browse/FLINK-8630
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming Connectors
>            Reporter: Xingcan Cui
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> To support (FLINK-8558), we need to generate a \{{TypeInformation}} from a standard
[JSON schema|http://json-schema.org/] (and maybe vice verse). There are some problems to be
discussed, e.g., how to handle JSON {{Number}} type. One option would be we always return
a specific type, which can be configured to be double or BigDecimal, for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message