flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8623) ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on Travis
Date Sat, 10 Feb 2018 07:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359307#comment-16359307

ASF GitHub Bot commented on FLINK-8623:

GitHub user zhangminglei opened a pull request:


    [FLINK-8623] ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuri…

    ## What is the purpose of the change
    Try to fix ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on Travis.

    ## Brief change log
    Change the behavior get localhost ```InetAddress``` to ```InetAddress.getByName("localhost")```
instead of ```InetAddress.getLocalHost()```, as the latter one will return the actual IP of
one of your network adapters.
    And in general ```InetAddress.getLocalHost()``` should be avoided.
    ## Verifying this change
    This change is already covered by existing tests, is ```testReturnLocalHostAddressUsingHeuristics```
in ```ConnectionUtilsTest.java```.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no )
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-8623

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5449
commit 67e70d558c7d2f47ed3f7a407ad250518a2f683c
Author: zhangminglei <zml13856086071@...>
Date:   2018-02-10T07:16:09Z

    [FLINK-8623] ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on


> ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on Travis
> --------------------------------------------------------------------------------
>                 Key: FLINK-8623
>                 URL: https://issues.apache.org/jira/browse/FLINK-8623
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.5.0
> {{ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics}} fails on Travis: https://travis-ci.org/apache/flink/jobs/339344442

This message was sent by Atlassian JIRA

View raw message