flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8617) Fix code generation bug while accessing Map type
Date Mon, 12 Feb 2018 09:47:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360506#comment-16360506
] 

ASF GitHub Bot commented on FLINK-8617:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5438#discussion_r167503729
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
    @@ -351,7 +351,7 @@ object ScalarOperators {
         else {
           s"""
             |${operand.code}
    -        |boolean $resultTerm = false;
    +        |boolean $resultTerm = ${operand.resultTerm} == null;
    --- End diff --
    
    This is not a bug but intended. The result type should be a primitive at this point. I
remove it and all tests are still working correctly.


> Fix code generation bug while accessing Map type
> ------------------------------------------------
>
>                 Key: FLINK-8617
>                 URL: https://issues.apache.org/jira/browse/FLINK-8617
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>
> There's a code generation bug in {code}ScalarOperatos.generateMapGet{code}.
> And there's two more bugs found in {code}ScalarOperators.generateIsNull{code} and {code}ScalarOperators.generateIsNotNull{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message