flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8603) Split RestClusterClient#submitJob into submitJob and requestJobResult
Date Thu, 08 Feb 2018 12:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356893#comment-16356893
] 

ASF GitHub Bot commented on FLINK-8603:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5428

    [FLINK-8603] [flip6] Split submitJob into job submission and execution result retrieval

    ## What is the purpose of the change
    
    Split RestClusterClient#submitJob into submitJob and requestJobResult which can
    be called individually.
    
    ## Verifying this change
    
    This change is already covered by existing tests. Moreover, I tested it manually.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink splitSubmitJob

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5428
    
----
commit dfacb8bd7358eb3be1caa9d7bb41658ec667b3d7
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-06T15:46:52Z

    [FLINK-8603] [flip6] Split submitJob into job submission and execution result retrieval
    
    Split RestClusterClient#submitJob into submitJob and requestJobResult which can
    be called individually.

----


> Split RestClusterClient#submitJob into submitJob and requestJobResult
> ---------------------------------------------------------------------
>
>                 Key: FLINK-8603
>                 URL: https://issues.apache.org/jira/browse/FLINK-8603
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{RestClusterClient}} currently combines the job submission and the {{JobResult}}
retrieval. These two operations should be two functions which return a respective future on
which you can wait. This will give more flexibility to users of the {{RestClusterClient}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message