flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8565) CheckpointOptionsTest unstable
Date Tue, 06 Feb 2018 13:12:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353858#comment-16353858
] 

ASF GitHub Bot commented on FLINK-8565:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5417

    [FLINK-8565][tests] Ensure locationBytes.length > 0 in CheckpointOptionsTest

    This PR fixes a test instability in `CheckpointOptionsTest#testSavepoint`. The tests generated
a byte array of a random size, which may also be 0. This caused an `IllegalArgumentException`
when being passed to the `CheckpointStorageLocationReference` constructor.
    
    We now add 1 to the randomly picked size, and compensate this addition by reducing the
upper bound by 1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8565

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5417
    
----
commit 6e22d496f0a92c93660f20e137e59cd30087e199
Author: zentol <chesnay@...>
Date:   2018-02-06T13:07:23Z

    [FLINK-8565][tests] Ensure locationBytes.length > 0

----


> CheckpointOptionsTest unstable
> ------------------------------
>
>                 Key: FLINK-8565
>                 URL: https://issues.apache.org/jira/browse/FLINK-8565
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing, Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>
> https://travis-ci.org/zentol/flink/jobs/337945528
> {code}
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.239 sec <<<
FAILURE! - in org.apache.flink.runtime.checkpoint.CheckpointOptionsTest
> testSavepoint(org.apache.flink.runtime.checkpoint.CheckpointOptionsTest)  Time elapsed:
0.037 sec  <<< ERROR!
> java.lang.IllegalArgumentException: null
> 	at org.apache.flink.util.Preconditions.checkArgument(Preconditions.java:123)
> 	at org.apache.flink.runtime.state.CheckpointStorageLocationReference.<init>(CheckpointStorageLocationReference.java:60)
> 	at org.apache.flink.runtime.checkpoint.CheckpointOptionsTest.testSavepoint(CheckpointOptionsTest.java:55)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message