flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods
Date Wed, 28 Feb 2018 13:10:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380280#comment-16380280

ASF GitHub Bot commented on FLINK-8560:

Github user kl0u commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/KeyedProcessOperator.java
    @@ -132,15 +139,15 @@ public TimerService timerService() {
    -	private class OnTimerContextImpl extends ProcessFunction<IN, OUT>.OnTimerContext{
    +	private class OnTimerContextImpl extends KeyedProcessFunction<K, IN, OUT>.OnTimerContext<K>
    --- End diff --
    With the proposed changes you can also remove the `<K>` in the `.OnTimerContext<K>`.

> add KeyedProcessFunction to expose the key in onTimer() and other methods
> -------------------------------------------------------------------------
>                 Key: FLINK-8560
>                 URL: https://issues.apache.org/jira/browse/FLINK-8560
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.4.0
>            Reporter: J├╝rgen Thomann
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
> Currently it is required to store the key of a keyBy() in the processElement method to
have access to it in the OnTimerContext.
> This is not so good as you have to check in the processElement method for every element
if the key is already stored and set it if it's not already set.
> A possible solution would adding OnTimerContext#getCurrentKey() or a similar method.
Maybe having it in the open() method could maybe work as well.
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Getting-Key-from-keyBy-in-ProcessFunction-tt18126.html

This message was sent by Atlassian JIRA

View raw message