flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8549) Move TimerServiceOptions to TaskManagerOptions
Date Fri, 02 Feb 2018 11:57:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350207#comment-16350207
] 

ASF GitHub Bot commented on FLINK-8549:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5402#discussion_r165626728
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
    @@ -206,6 +206,14 @@
     			key("task.cancellation.timeout")
     			.defaultValue(180000L);
     
    +	/**
    +	 * This configures how long we wait for the timers to finish all pending timer threads
    +	 * when the stream task is cancelled .
    +	 */
    +	public static final ConfigOption<Long> TASK_CANCELLATION_TIMEOUT_TIMERS = ConfigOptions
    +			.key("task.cancellation.timeout.timers")
    +			.defaultValue(7500L);
    --- End diff --
    
    Good point - I just checked, it was in fact already part of 1.4 (I had falsely in my mind
that it was new in 1.5)


> Move TimerServiceOptions to TaskManagerOptions
> ----------------------------------------------
>
>                 Key: FLINK-8549
>                 URL: https://issues.apache.org/jira/browse/FLINK-8549
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> The {{TimerServiceOptions}} are in the wrong place (prohibit generation of config docs)
and cause over-fragmentation of the options in the code base.
> I propose to simple move the one option from that class to the {{TaskManagerOptions}},
as it relates to task execution. Other shutdown related options are in there already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message