flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8423) OperatorChain#pushToOperator catch block may fail with NPE
Date Tue, 13 Feb 2018 08:55:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362009#comment-16362009
] 

ASF GitHub Bot commented on FLINK-8423:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5447


> OperatorChain#pushToOperator catch block may fail with NPE
> ----------------------------------------------------------
>
>                 Key: FLINK-8423
>                 URL: https://issues.apache.org/jira/browse/FLINK-8423
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.5.0, 1.4.2
>
>
> {code}
> @Override
> protected <X> void pushToOperator(StreamRecord<X> record) {
> 	try {
> 		// we know that the given outputTag matches our OutputTag so the record
> 		// must be of the type that our operator (and Serializer) expects.
> 		@SuppressWarnings("unchecked")
> 		StreamRecord<T> castRecord = (StreamRecord<T>) record;
> 		numRecordsIn.inc();
> 		StreamRecord<T> copy = castRecord.copy(serializer.copy(castRecord.getValue()));
> 		operator.setKeyContextElement1(copy);
> 		operator.processElement(copy);
> 	} catch (ClassCastException e) {
> 		// Enrich error message
> 		ClassCastException replace = new ClassCastException(
> 			String.format(
> 				"%s. Failed to push OutputTag with id '%s' to operator. " +
> 				"This can occur when multiple OutputTags with different types " +
> 				"but identical names are being used.",
> 				e.getMessage(),
> 				outputTag.getId()));
> 		throw new ExceptionInChainedOperatorException(replace);
> 	} catch (Exception e) {
> 		throw new ExceptionInChainedOperatorException(e);
> 	}
> }
> {code}
> If outputTag is null (as is the case when no sideOutput was defined) the catch block
will crash with a NullPointerException. This may happen if {{operator.processElement}} throws
a ClassCastException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message