flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working
Date Fri, 02 Feb 2018 14:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350430#comment-16350430
] 

ASF GitHub Bot commented on FLINK-8275:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5172#discussion_r165636080
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
    @@ -142,19 +153,10 @@ public static void runYarnTaskManager(String[] args, final Class<?
extends YarnT
     
     			SecurityUtils.install(sc);
     
    -			SecurityUtils.getInstalledContext().runSecured(new Callable<Object>() {
    -				@Override
    -				public Integer call() {
    -					try {
    -						TaskManager.selectNetworkInterfaceAndRunTaskManager(configuration, resourceId,
taskManager);
    -					}
    -					catch (Throwable t) {
    -						LOG.error("Error while starting the TaskManager", t);
    -						System.exit(TaskManager.STARTUP_FAILURE_RETURN_CODE());
    -					}
    -					return null;
    -				}
    -			});
    +			if (mainRunner == null) {
    --- End diff --
    
    Not sure about this.
    This is basically adding a non-production code relevant path in for testing purposes (i.e.,
it is only ever non-null in the `YarnTaskManagerRunnerTest`).
    
    I think it would be better if we have a `protected createMainRunner(...)` method that
can be overriden to inject the mock runner dependency for testing.


> Flink YARN deployment with Kerberos enabled not working 
> --------------------------------------------------------
>
>                 Key: FLINK-8275
>                 URL: https://issues.apache.org/jira/browse/FLINK-8275
>             Project: Flink
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 1.4.0
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.1
>
>
> The local keytab path in YarnTaskManagerRunner is incorrectly set to the ApplicationMaster's
local keytab path. This causes jobs to fail because the TaskManager can't read the keytab.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message